Forcekilltmp #3
Draft
Forcekilltmp #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The force option gives the option to skip any action the process does to properly release resources. This can result in orphan resources (e.g. submitted jobs that are still running). To test the feature we have to monkey patch the workers code. We thus start a worker in a forked process to inherit the monkey patched python context. The fixture `fork_worker_context` returns a context manager that starts the worker with the aiida test profile and terminates it.
for more information, see https://pre-commit.ci
I changed the killing calcjob to a the mock RunningProcess that stays in running state. The tests before were not really testing if it was killable during the running state as the ArithmeticAdd CalcJob goes immediately to the Waiting state (while it is sleeping it is in waiting state) and is then killable. Running can be blocking if the run_fn is blocking, so no kill command can go through. I am not sure if it makes sense to test these cases, since in the end we want to test if a CalcJob does not get stuck during killing, we do not care so much about custom Processes. I would go forward by only using ArithmeticAdd calcjob in the tests 1-6. From the tests for the EBM 7-11 I only kept 7. I think it is not important to test that kill is getting stuck. I see some value in the test 9, but kept it short for now. Let me know your opinion about which tests to keep, I think before it were too many.
for more information, see https://pre-commit.ci
- Replace {Running,Waiting}Process with ArithmeticAddCalculation.
- Add tests 8),9) back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.